Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new config searching path #79

Merged
merged 12 commits into from
Oct 14, 2024
Merged

new config searching path #79

merged 12 commits into from
Oct 14, 2024

Conversation

gzm55
Copy link
Contributor

@gzm55 gzm55 commented Mar 19, 2024

fix #78

@gzm55
Copy link
Contributor Author

gzm55 commented May 17, 2024

@flavio could u plz review this pr?

@gzm55 gzm55 mentioned this pull request Oct 4, 2024
Closed
@gzm55
Copy link
Contributor Author

gzm55 commented Oct 5, 2024

@flavio $KUBERLR_CFG is ready here

flavio
flavio requested changes Oct 7, 2024
View reviewed changes
Copy link
Owner

@flavio flavio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, I left some comments.

Please update also the README to mention the new environment variable.

internal/config/config.go Outdated Show resolved Hide resolved
internal/config/config.go Outdated Show resolved Hide resolved
internal/config/config_test.go Outdated Show resolved Hide resolved
internal/config/paths_unix.go Outdated Show resolved Hide resolved
internal/config/paths_windows.go Outdated Show resolved Hide resolved
@gzm55
Copy link
Contributor Author

gzm55 commented Oct 7, 2024

Overall LGTM, I left some comments.

Please update also the README to mention the new environment variable.

@flavio new env is listed in the README

@gzm55
Copy link
Contributor Author

gzm55 commented Oct 14, 2024

@flavio any suggestion on this pr?

flavio
flavio approved these changes Oct 14, 2024
View reviewed changes
Copy link
Owner

@flavio flavio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late response, it has been a busy week

@flavio flavio merged commit 4394fb3 into flavio:master Oct 14, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flavio flavio flavio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add installation-level config path
2 participants
@gzm55 @flavio